fix(compass-schema): fix geoLayers callbacks COMPASS-9540 #7099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing callbacks for geoLayers actions in the schema store and adds tests to ensure those callbacks are invoked correctly.
- Updated
geoLayerAdded,geoLayersEdited, andgeoLayersDeletedto accept and call callbacks with the generated geo query. - Added unit tests in
store.spec.tsto verify each callback is invoked with the correct query shape. - Imported
Circle,LayerGroup, andPolygonin tests to construct layer examples.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-schema/src/stores/store.spec.ts | Added tests for geoLayerAdded, geoLayersEdited, geoLayersDeleted callbacks and imported Leaflet types. |
| packages/compass-schema/src/stores/schema-analysis-reducer.ts | Updated geoLayers action creators to accept onAdded/onEdited/onDeleted callbacks and invoke them with generateGeoQuery instead of returning it. |
Comments suppressed due to low confidence (2)
packages/compass-schema/src/stores/schema-analysis-reducer.ts:154
- Add or update JSDoc comments for
geoLayerAdded,geoLayersEdited, andgeoLayersDeletedto document the new callback parameters (onAdded,onEdited,onDeleted), explaining when and with what arguments they are invoked.
export const geoLayerAdded = (
packages/compass-schema/src/stores/schema-analysis-reducer.ts:183
- [nitpick] Each call to
geoLayerAddedwithingeoLayersEditedstill executesgenerateGeoQueryfor every intermediate layer, even though those results are discarded; consider extendinggeoLayerAddedto accept an option to batch updates or skip intermediate callbacks to avoid unnecessary query generation.
geoLayerAdded(field, layer, () => {
addaleax
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was broken when during the reflux -> redux rewrite, I missed to call the callbacks. Added tests so that this is covered for the next person.
With this change, adding a geoLayer works, unfortunately the edit & delete are just never triggered by
react-leaflet-draw. I will create a separate ticket to update the leaflet libraries, which are on very old versions (but we can't go to the newest with react 17)Checklist
Motivation and Context
Open Questions
Dependents
Types of changes